config: refactor LoadDefaultConfig to take in context and concrete options
#951
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skotambkar
force-pushed
the
load-dflt-config
branch
2 times, most recently
from
6707f3b
to
973a2ac
Compare
jasdel
suggested changes
Dec 7, 2020
skotambkar
force-pushed
the
load-dflt-config
branch
from
973a2ac
to
d1a77c7
Compare
jasdel
suggested changes
Dec 11, 2020
jasdel
approved these changes
Dec 11, 2020
|
This PR will need to b paired with doc/example change |
|
Fixed in #951 |
This was referenced Dec 17, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactors config's
LoadDefaultConfigutil to take in a context and LoadOptions functional options, to replace usage of empty interface{}address config: Design of LoadDefaultConfig options is very generic, allows invalid loading options #926 and config: LoadDefaultConfig should require passing context.Context during config loading. #819